Repository navigation
Update deprecated keyboard event props - #697
Open
chilled-capybara wants to merge 3 commits into
Open
chilled-capybara wants to merge 3 commits into
chilled-capybara wants to merge 3 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #697 +/- ##
=======================================
Coverage 98.94% 98.94%
=======================================
Files 56 56
Lines 2458 2458
Branches 747 740 -7
=======================================
Hits 2432 2432
Misses 24 24
Partials 2 2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
|
Conflicted |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #696.
Typescript doesn't contain the defintions for
event.keyso these have been done asstrings.This could possibly be achieved by adding support in
rc-utilor using something likets-key-enum.I've updated the relevant commented-out code just to ensure the meaning isn't lost. Also, I've run
prettieron the files I've worked on, the unrelated changes are in a dedicated commit.